[release-4.20] OCPBUGS-85523: Remove restriction of unmanaged x-k8s.io#31167
Conversation
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.
Signed-off-by: Ricardo Pchevuzinske Katz <katz@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-74373 has been cloned as Jira Issue OCPBUGS-85523. Will retitle bug to link to clone. WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone. /retitle [release-4.20] OCPBUGS-85523: Remove restriction of unmanaged x-k8s.io DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/severity-low
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85523, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is an automated cherry-pick of #30718
/assign rikatz